Replace run methods #585
Merged
Replace run methods #585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olleolleolle
approved these changes
Jan 27, 2019
| @@ -116,13 +116,75 @@ def eot | |||
| # The command to by run | |||
| # | |||
| # @see #cmd | |||
| # @deprectated | |||
| # @deprecated | |||
unasuke
added a commit
to unasuke/middleman
that referenced
this pull request
Jan 23, 2020
Aruba's #run methods now deprecated. Use new method #run_command. - cucumber/aruba#585
tdreyno
pushed a commit
to middleman/middleman
that referenced
this pull request
Jan 29, 2020
* Use #run_command instead of #run Aruba's #run methods now deprecated. Use new method #run_command. - cucumber/aruba#585 * Use #set_environment_variable instead of #set_env Aruba's #set_env methods now deprecated. Use new method #set_environment_variable. - cucumber/aruba@663991ec7 * Use #expand_path instead of #current_dir Aruba's #current_dir now deprecated. Use new method #expand_path. - cucumber/aruba@802c4ec242 * Use aruba.announcer instead of #announcer Aruba's #announcer now deprecated. Use new method aruba.announcer. - cucumber/aruba@7f8a155c89
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix #559.
Details
Deprecates
#runand#run_simplein favor of#run_commandand#run_command_and_stop, and uses the new methods everywhere.Motivation and Context
Makes the eventual transition to 1.0 smoother for users.
How Has This Been Tested?
Full suite has been run to check for (deprecation) errors.
Types of changes
Checklist: