fix @no-clobber breaking process management (closes

[doudou]

Summary

When a scenario has @no-clobber, Aruba would not call Setup#call at all, which causes the
process monitor to not be listening to process events.

Details

Changed Setup#call to accept a 'clobber' argument and set it according to whether there is @no-clobber or ~@no-clobber.

Motivation and Context

Closes #527

How Has This Been Tested?

THERE ARE NO TESTS YET I'm just not sure where it is appropriate to test for this. It's weird to do this in a cucumber feature, as it's testing a regression and not a feature, but then we should check that @no-clobber and process monitoring work (which can only be done in cucumber). It's going to look weird in the cucumber.pro site, no ?

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Refactoring (cleanup of codebase withouth changing any existing functionality)
• Update documentation

Checklist:

• I've added tests for my code
• My change requires a change to the documentation.
• I have updated the documentation accordingly.

[mvz]

I'll give the testing options some thought.

[mvz]

The implementation seems good, in any case 👍

[mvz]

I think the best option is to extend the existing scenario for @no-clobber. A check that the working directory is reset is a good option.

[mvz]

I've tested this with updated scenarios and it works like a charm. I'll include those scenerios and merge this.

[aslakhellesoy]

Hi @doudou,

Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾

In return for this generous offer we hope you will:

• ✅ Continue to use branches and pull requests. When someone on the core team approves a pull request (yours or someone else's), you're welcome to merge it yourself.
• 💚 Commit to setting a good example by following and upholding our code of conduct in your interactions with other collaborators and users.
• 💬 Join the community Slack channel to meet the rest of the team and make yourself at home.
• ℹ️ Don't feel obliged to help, just do what you can if you have the time and the energy.
• 🙋 Ask if you need anything. We're looking for feedback about how to make the project more welcoming, so please tell us!

On behalf of the Cucumber core team,
Aslak Hellesøy
Creator of Cucumber

[mvz]

I'll create another PR for the master branch.

[olleolleolle]

@mvz Thanks for taking this into Aruba!

[olleolleolle]

@doudou Awesome! Thanks!