Fix final cuke failures

[mvz]

Summary

Fixes the remaining cucumber scenarios.

Details

• Ensures at least one command is stopped before checking its exit status. Also updates the behavior described in the corresponding cucumber feature.
• Adjust the should( not)? (pass|fail) steps to do the same.
• Fix the aruba version matcher in the build-aruba feature.
• Fix the fixture feature not cause syntax errors and also actually run specs in each scenario.

Motivation and Context

This final change should make the full cucumber suite pass.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• Documentation fix

[mvz]

This did not have the intended result on Travis. I'm going to investigate.

[mvz]

All relevant builds are green!

[mvz]

After this, I want to tackle #432.

[aslakhellesoy]

Hi @mvz,

Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾

In return for this generous offer we hope you will:

• ✅ Continue to use branches and pull requests. When someone on the core team approves a pull request (yours or someone else's), you're welcome to merge it yourself.
• 💚 Commit to setting a good example by following and upholding our code of conduct in your interactions with other collaborators and users.
• 💬 Join the community Slack channel to meet the rest of the team and make yourself at home.
• ℹ️ Don't feel obliged to help, just do what you can if you have the time and the energy.
• 🙋 Ask if you need anything. We're looking for feedback about how to make the project more welcoming, so please tell us!

On behalf of the Cucumber core team,
Aslak Hellesøy
Creator of Cucumber

[maxmeyer]

But besides the comment I'm happy you fixed things! Thanks a lot!

[mvz]

stop_all_commands is too drastic in this case, since some scenarios explicitly stop one command and check that command's exit status.