-
-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moving code to separate classes #245
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't see the relation to the topics mentioned in #231. But never mind. Regarding this PR: It seems like you have seen some light that haven't reached me yet and it will take some time for me to get there... I will just say that at first glance it all seems ok, for the rest of it I'll just trust you.. |
Merged into #257 |
ghost
closed this
Jun 2, 2015
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first PR for #231. I kept the commits as isolated as possible, to make it easier to review the changes.
This PR is not yet finished. I think it needs to be discussed first. All "old" tests are passing with this code. It also duplicates the
capture
-method I used in some other PR. I only added it to make the tests pass. The documentation is not complete. Tests needs to be written.Besides that I'm quite happy with the code:
lib/aruba/announcer.rb
announce_or_puts
-method is gone and replaced bymode=
default_announcer
which writes to/dev/null
and an announcer which writes to what ever announcer was chosen bymode=
- e.g.Kernel.puts
,puts
Hash
, but decided against it because we would end up with different activatedAnnouncers
if the mode is changed between two activationsProcessMonitor
- BTW I'm open to rename if one of you guys has a better idea.@jarl-dk @mattwynne
Suggestions?