Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rethink bootstrap script #582

Closed
mvz opened this issue Jan 8, 2019 · 2 comments
Closed

Rethink bootstrap script #582

mvz opened this issue Jan 8, 2019 · 2 comments

Comments

@mvz
Copy link
Contributor

mvz commented Jan 8, 2019

Summary

Investigate whether bin/bootstrap/script/bootstrap still makes sense and does the right thing.

Expected Behavior

bootstrap needs to have significant advantages over the default gem development workflow (i.e., bundle install).

Current Behavior

In addition to bundle install, bootstrap installs Bundler for you and checks that you have Ruby installed. These seem superfluous to me.

In still, bootstrap also checks for some external programs. I think these can be made optional, like in master.

Possible Solution

Remove bootstrap and update the instructions accordingly.

Context & Motivation

Use of bootstrap makes the Travis configuration more custom than it needs to be. Juggling its dual-use (setup of local environment, versus setup of CI environment) made fixing problems in #581 more complex.

@olleolleolle
Copy link
Contributor

Remove the script, update docs: best solution here, I think.

olleolleolle added a commit to olleolleolle/aruba that referenced this issue Feb 14, 2019
@olleolleolle
Copy link
Contributor

Fixed in #593.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants