Merge cockroachdb#81092

81092: testutils: remove stack trace from SucceedsWithin r=stevendanna a=tbg It has `t.Helper()` so it will already show the caller. Release note: None Co-authored-by: Tobias Grieger <[email protected]>
cucaroach · May 23, 2022 · a34d9c1 · a34d9c1
2 parents 1a8ce4b + 6c55ba9
commit a34d9c1
Showing 1 changed file with 1 addition and 3 deletions.
diff --git a/pkg/testutils/soon.go b/pkg/testutils/soon.go
@@ -12,7 +12,6 @@ package testutils
 
 import (
 	"context"
-	"runtime/debug"
 	"time"
 
 	"github.com/cockroachdb/cockroach/pkg/util"
@@ -56,8 +55,7 @@ func SucceedsSoonError(fn func() error) error {
 func SucceedsWithin(t TB, fn func() error, duration time.Duration) {
 	t.Helper()
 	if err := SucceedsWithinError(fn, duration); err != nil {
-		t.Fatalf("condition failed to evaluate within %s: %s\n%s",
-			duration, err, string(debug.Stack()))
+		t.Fatalf("condition failed to evaluate within %s: %s", duration, err)
 	}
 }