sql: remove write to time.Local and use env var instead (cockroachdb#…

…40336)

Release note: none

Makefile

@@ -220,8 +220,10 @@ LDFLAGS ?=
 CGO_CFLAGS = $(filter-out -g%,$(CFLAGS))
 CGO_CXXFLAGS = $(CXXFLAGS)
 CGO_LDFLAGS = $(filter-out -static,$(LDFLAGS))
+# certain time based fail if UTC isn't the default timezone
+TZ=""
 
-export CFLAGS CXXFLAGS LDFLAGS CGO_CFLAGS CGO_CXXFLAGS CGO_LDFLAGS
+export CFLAGS CXXFLAGS LDFLAGS CGO_CFLAGS CGO_CXXFLAGS CGO_LDFLAGS TZ
 
 # We intentionally use LINKFLAGS instead of the more traditional LDFLAGS
 # because LDFLAGS has built-in semantics that don't make sense with the Go

build/variables.mk

@@ -139,6 +139,7 @@ define VALID_VARS
   TESTTIMEOUT
   TSC
   TYPE
+  TZ
   UI_CCL_DLLS
   UI_CCL_MANIFESTS
   UI_JS_CCL

pkg/sql/logictest/logic.go

@@ -3163,9 +3163,6 @@ func RunLogicTestWithDefaultConfig(
 		globs = []string{*logictestdata}
 	}
 
-	// Set time.Local to time.UTC to circumvent pq's timetz parsing flaw.
-	time.Local = time.UTC
-
 	// A new cluster is set up for each separate file in the test.
 	var paths []string
 	for _, g := range globs {