Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
makefile: add vendor/modules.txt target for ordering
Developers trying to run `make build` from a fresh checkout have reported hitting: ``` make build Running make with -j8 GOPATH set to /Users/someuser/go make: *** No rule to make target 'vendor/modules.txt', needed by 'bin/.bootstrap'. Stop. ``` Using `remake`'s tracing feature, we can see that the problem appears to be that `bin/.bootstrap` depends on both `vendor/modules.txt` and `bin/.submodules-initialized`. While `bin/.submodules-initialized` would create `vendor/modules.txt`, make is choosing to run `vendor/modules.txt` first: ``` > GOPATH=~/cleango/ remake -j1 --trace build Reading makefiles... GOPATH set to /Users/ssd/cleango Updating makefiles... Updating goal targets... File 'build' does not exist. File 'cockroach' does not exist. File 'pkg/ui/distccl/bindata.go' does not exist. File 'bin/.bootstrap' does not exist. File 'vendor/modules.txt' does not exist. Must remake target 'vendor/modules.txt'. ``` Adding a target for `vendor/modules.txt` with an empty recipe encodes fixes up the dependnecy issue. Release note: None
- Loading branch information