This repository has been archived by the owner on Mar 27, 2019. It is now read-only.
Do not execute event handler if not enabled and event type is touchca… #1079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ncel.
handleEvent registers event listeners for the various touch events: touchstart, touchmove, touchend AND touchcancel.
Event listeners check the state of IScroll and the event type and decide if they can run:
> if ( !this.enabled || utils.eventType[e.type] !== this.initiated ) {
> return;
> }
this.enabled ist set to true in the construct method IScroll.
utils.eventType is undefined for e.type === "touchcancel", as is this.initiated if you are scrolling outside your wrapper and _start was not executed.
Both expressions evaluate to false and thus the event listeners execute.
(SEO: Found the problem on Android 4.4.2 Webview, which emits touchcancel events)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ncel.
handleEvent registers event listeners for the various touch events: touchstart, touchmove, touchend AND touchcancel.
Event listeners check the state of IScroll and the event type and decide if they can run:
this.enabled ist set to true in the construct method IScroll.
utils.eventType is undefined for e.type === "touchcancel", as is this.initiated if you are scrolling outside your wrapper and _start was not executed.
Both expressions evaluate to false and thus the event listeners execute.
(SEO: Found the problem on Android 4.4.2 Webview, which emits touchcancel events)