Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #29; instant snap back when looping: false #70

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dokterbob
Copy link

Based on the suggestions in #29, I have removed dist = 0 around line 373 which seems to have been used in the if statement later on. Instead, I have assigned the condition to a variable and have OR'ed that with the original condition.

This seems to work for me but I would love additional feedback from the original participants in the issue report (@ghost, @MathieuLoutre and @linlex).

@MathieuLoutre
Copy link

Hey! Great to see some work on this. Unfortunately I haven't used this library in over a year and I'm not sure my comments would be terribly helpful. I think I remember what the problem was and your fix is probably more readable than the one I suggested at the time (which required an understanding of the code structure). Basically, I haven't tried it, but it doesn't look bad :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants