Skip to content

Commit

Permalink
[rome.json] Group rules by how long we should keep them around.
Browse files Browse the repository at this point in the history
Keep forever:

- `js/noDelete`
- `js/noNegationElse`
- `js/noShoutyConstants`

May require checking that Rome is detecting things correctly:

- `js/noUnusedVariables` (see rome/tools#3183)
- `js/noUnnecessaryContinue`

To refactor (some of these are frivolous, but they generally don't hurt):

- `js/useSingleCaseStatement`
- `js/noUnusedTemplateLiteral`
- `js/useTemplate`
- `js/useSimplifiedLogicExpression`
- `js/useSingleVarDeclarator`
- `js/useBlockStatements`
- `js/noDoubleEquals`
- `js/noArguments`
- `js/noAsyncPromiseExecutor`
- `ts/useShorthandArrayType`
  • Loading branch information
lgarron committed Sep 10, 2022
1 parent 7b0dec4 commit 34f4f96
Showing 1 changed file with 6 additions and 4 deletions.
10 changes: 6 additions & 4 deletions rome.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,19 +9,21 @@
"js": {
"recommended": true,
"noDelete": "off",
"noNegationElse": "off",
"noShoutyConstants": "off",

"noUnusedVariables": "off",
"noUnnecessaryContinue": "off",

"useSingleCaseStatement": "off",
"noUnusedTemplateLiteral": "off",
"useTemplate": "off",
"useSimplifiedLogicExpression": "off",
"noNegationElse": "off",
"useSingleVarDeclarator": "off",
"useBlockStatements": "off",
"noDoubleEquals": "off",
"noArguments": "off",
"noAsyncPromiseExecutor": "off",
"noShoutyConstants": "off",
"noUnnecessaryContinue": "off"
"noAsyncPromiseExecutor": "off"
},
"ts": {
"recommended": true,
Expand Down

0 comments on commit 34f4f96

Please sign in to comment.