Revert "Implement NumPy's __array_function__ protocol for array methods that are not in the Array API Standard"
#469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hods tha…" This reverts commit af1ab74.
|
Can you elaborate on what exactly goes wrong with this approach? |
Yes, of course. With this change Xarray now thinks that it can use Switching the order here (i.e. check for Any thoughts about how to proceed? |
5 tasks
|
Thoughts in pydata/xarray#8834 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #468
This is causing problems when running with xarray, so I'm reverting it for the time being.