Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove some xfails #24

Merged
merged 2 commits into from
Sep 23, 2024
Merged

Remove some xfails #24

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f62d351
Remove xfail for test_chunk due to Cubed #546 fix
tomwhite Sep 23, 2024
39921ad
Remove xfail for test_unary_op (round) due to Xarray #9326 fix
tomwhite Sep 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions cubed_xarray/tests/test_xarray.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,9 +86,6 @@ def test_copy(self):
self.assertLazyAndIdentical(self.eager_var, self.lazy_var.copy())
self.assertLazyAndIdentical(self.eager_var, self.lazy_var.copy(deep=True))

@pytest.mark.xfail(
reason="cubed rechunk handles chunks={} incorrectly, see https://github.com/cubed-dev/cubed/pull/546"
)
def test_chunk(self):
for chunks, expected in [
({}, ((2, 2), (2, 2, 2))),
Expand Down Expand Up @@ -151,7 +148,7 @@ def test_unary_op(self):
v = self.lazy_var
self.assertLazyAndIdentical(-u, -v)
self.assertLazyAndIdentical(abs(u), abs(v))
# self.assertLazyAndIdentical(u.round(), v.round()) # TODO: fails, see https://github.com/pydata/xarray/pull/9326
self.assertLazyAndIdentical(u.round(), v.round())

def test_binary_op(self):
u = self.eager_var
Expand Down Expand Up @@ -292,9 +289,6 @@ def setUp(self):
self.data, coords={"x": range(4)}, dims=("x", "y"), name="foo"
)

@pytest.mark.xfail(
reason="cubed rechunk handles chunks={} incorrectly, see https://github.com/cubed-dev/cubed/pull/546"
)
def test_chunk(self) -> None:
for chunks, expected in [
({}, ((2, 2), (2, 2, 2))),
Expand Down