Basic cube representation types

[hoisinberg]

No description provided.

[KeijiBranshi]

All of these should probably just be .ts files. Only need .tsx when you're using React components

[KeijiBranshi]

I think namespaces are discouraged (or rather, not preferred) in TS/JS. Will need @itstang to fact check me on this, but for es6 the file itself is effectively the "namespace":
https://michelenasti.com/2019/01/23/is-typescript-namespace-feature-deprecated.html
microsoft/TypeScript#30994

[KeijiBranshi]

to keep the grouping you can also make it an object. Or, I see dimension as an argument for both functions. You could curry that out and make this a factory.

[itstang]

+1 would probably recommend using es6 standard modules over namespaces

[hoisinberg]

Makes sense. I've moved the static factory methods into a factory object.

[KeijiBranshi]

idk if you want to add more context to these primitives (e.g. number). But if so, you can make type aliases:

type Facelet = number;
type Color = "red" | "white" | "blue" | "green" | "orange" | "yellow"

then reference the alias instead of number

[itstang]

I think he might want to abstract way from specific colors and just be able to use facelet indicies, in which case I don't think there's a simple way where we can enforce that type

[KeijiBranshi]

yeah, the color was just meant to show what you can do with types. The Facelet = number is the more relevant example.

[hoisinberg]

That's neat. Done.