feat(cubesql): Initial SQL pushdown flattening #8888
Draft
+2,255
−585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This case is already covered with compile::test::test_wrapper::test_wrapper_limit_zero
…h_to_cube This name seems more appropriate, because actual WrappedSelect can represent grouped query when this field is set to true
…up replacers It is used to track whether this query actually wraps ungrouped scan in from as opposed to old flag, which is used as push to cube enabler
…members_wrapper cost component
…out push to Cube * New wrapped_no_push_to_cube cost component, necessary when two wrappers does not differ at all, only by push_to_cube flag
…uped=true)) with enabled push to Cube This is necessary to build proper representations for flattening
Some queries in tests reduced to a single CubeScan with member expressions, so tests have changed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check List
Description of Changes Made (if issue reference is not provided)
[Description goes here]