Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cubesql): Add forgotten Distinct in ast_size_outside_wrapper cost component #8882

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mcheshkov
Copy link
Member

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Copy link

vercel bot commented Oct 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
examples-angular-dashboard ⬜️ Ignored (Inspect) Oct 29, 2024 10:23pm
examples-react-d3 ⬜️ Ignored (Inspect) Oct 29, 2024 10:23pm
examples-react-pivot-table ⬜️ Ignored (Inspect) Oct 29, 2024 10:23pm

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 82.49%. Comparing base (bbb114e) to head (ef9d11e).

Files with missing lines Patch % Lines
rust/cubesql/cubesql/src/compile/rewrite/cost.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8882      +/-   ##
==========================================
- Coverage   82.50%   82.49%   -0.01%     
==========================================
  Files         221      221              
  Lines       77606    77607       +1     
==========================================
- Hits        64028    64023       -5     
- Misses      13578    13584       +6     
Flag Coverage Δ
cubesql 82.49% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mcheshkov mcheshkov marked this pull request as ready for review October 30, 2024 01:13
@mcheshkov mcheshkov requested a review from a team as a code owner October 30, 2024 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant