Groups accumulator primitive #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srh
force-pushed
the
groups-accumulator-primitive
branch
from
0608859 to
3c49011
Compare
|
(Squashed the style changes together and force-pushed to get the github checks to rerun, now that the arrow-rs branch is merged.) |
waralexrom
approved these changes
Nov 26, 2024
srh
force-pushed
the
groups-accumulator-primitive
branch
from
3c49011 to
594d1ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: cube-js/arrow-rs#45 needs to be merged before this. Because Cargo.lock is not committed in this repo, no pointer update will be needed.
This adds PrimitiveGroupsAccumulator and makes the Sum GroupsAccumulator much faster by directly building a PrimitiveArray instead of using a
Vec<ScalarValue>. This is based on upstream datafusion code. Note that NullState is also based on upstream datafusion code. Some of it is adapted, kind of awkwardly, to existing Arrow datatypes that are slightly different, in how they have offsets or lengths.