Replace debouncing code for ErgoDox #44
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old debouncing code blocked the whole keyboard for several milliseconds when a single key was pressed, only afterwards a key press was signalled to the host. This code changes two things: * On the initial edge, the key press is directly signalled to the host * Afterwards, that particular key is blocked for DEBOUNCE number of matrix scans, the others are read and signalled as usual
|
So, anything else I can do to get this merged? |
squarefrog
reviewed
Sep 26, 2018
There was a problem hiding this comment.
Seems fine to me. I briefly tested it and found no issues. However I have recently switched over to using QMK daily, so I'd have to pass the final say over to @marknsikora
|
Is there anything else to do? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old debouncing code blocked the whole keyboard for several milliseconds when a single key was pressed, only afterwards a key press was signalled to the host.
This code changes two things:
On the initial edge, the key press is directly signalled to the host
Afterwards, that particular key is blocked for DEBOUNCE number of matrix scans, the others are read and signalled as usual
Tested and verified to work on my ErgoDox keyboard.
See #43