Improve handling of component props updating #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added storybook back
Added touchscreen functionality for resizing
Improving the handling of component state changes
…oncrafter into RB-state-change-fix
…oftware/editioncrafter into RB-state-change-fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR
useEffectcall to theDocumentViewcomponent to listen for changes to the config props passed to the component (e.g. the manifest link, document name, etc) and dispatch an action to the Redux store to reload the document and glossary data. This improves the previous behavior in this situation, namely just crashing and displaying a blank page.folioIDvalues in the URL parameters is not actually included in the folio list; that pane will now redirect back to the grid view in that case.