chore: minor, non-functional changes #876
Conversation
* remove `actionThunks` variable from `extractDataFromModel` which was no longer in use
* this is for developers who are configured to use private registries at work. configuring at the project level will override any global configuration for commands like `npm publish`.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| @@ -26,7 +26,6 @@ export default function extractDataFromModel( | |||
| const _aCD = {}; | |||
| const _aC = {}; | |||
| const _aRD = {}; | |||
| const actionThunks = {}; | |||
There was a problem hiding this comment.
As far as I can tell, this was never being used. All tests still pass.
| const logEventListenerError = (type, err) => { | ||
| // eslint-disable-next-line no-console | ||
| console.log(`Error in ${type}`); | ||
| // eslint-disable-next-line no-console | ||
| console.log(err); | ||
| }; | ||
|
|
||
| export const handleEventDispatchErrors = | ||
| (type, dispatcher) => | ||
| (...args) => { | ||
| try { | ||
| const result = dispatcher(...args); | ||
| if (isPromise(result)) { | ||
| result.catch((err) => { | ||
| logEventListenerError(type, err); | ||
| }); | ||
| } | ||
| } catch (err) { | ||
| logEventListenerError(type, err); | ||
| } | ||
| }; |
There was a problem hiding this comment.
Make the code a bit more DRY by replacing repeated code with shared util.
| @@ -7,7 +7,7 @@ const noopStorage = { | |||
| removeItem: () => undefined, | |||
| }; | |||
|
|
|||
| const getBrowerStorage = (storageName) => { | |||
| const getBrowserStorage = (storageName) => { | |||
There was a problem hiding this comment.
For devs that use private NPM registries. Avoid conflicts with commands like npm publish
jmyrland
changed the title
| // Register the thunk handler | ||
| set(path, actionThunks, def.thunkHandler); | ||
|
|
There was a problem hiding this comment.
Maybe we don't have tests covering this? IDK what actionThunks are
There was a problem hiding this comment.
I've tested this branch against our codebase, and we get 0 failures - so I guess this is fine.
There was a problem hiding this comment.
Yeah, this is related to this change: #876 (comment). The only place actionThunks was ever being used was here, the thunkHandler was being set on the object but then the object never got passed along to anything else. And if all the tests still pass, I'm thinking it's fine. Ctrl + Shift + F also turned up no other references to actionThunks. Obviously this isn't definitive because it could be passed to a func that calls it something else, but if deleting this line doesn't break anything else I think we're good.
handleEventDispatchErrorsto lib