bugfix: persist not working on iOS #836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`createPersistor` defines a `timingMethod` that won't work on iOS. This is because this method utilizes `requestIdleCallback`, which is defined on iOS - but never invoked 🤯 So, for iOS we have to fallback to utilize `requestAnimationFrame`. This is done by vendoring a specific file `timingMethod.ios.js`, which the RN bundle can import for the iOS platform.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
I'm not able to verify if this is working, as I currently don't have a mac to test this on :/ |
This was
linked to
issues
Jun 12, 2023
|
Verified and tested on https://snack.expo.dev/_fo68oUf7 Notice how |
jmyrland
changed the title
no-stack-dub-sack
approved these changes
Jun 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
createPersistordefines atimingMethodthat won't work on iOS.This is because this method utilizesrequestIdleCallback, which is defined on iOS - but never invoked 🤯So, for iOS we have to fallback to utilizerequestAnimationFrame. This is done by vendoring a specific filetimingMethod.ios.js, which the RN bundle can import for the iOS platform.It turns out that the pollyfilled
requestIdleCallbackfor RN on iOS, requires a second parameter with a specific timeout - where as the native implementation does not. Setting the specific parameter invokes this function across all platforms.fixes #694
fixes #599