Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Release effectOn & prepare for v6.0.0 #813

Merged
merged 3 commits into from
Apr 18, 2023
Merged

Conversation

jmyrland
Copy link
Collaborator

@jmyrland jmyrland commented Jan 19, 2023

  • Refactors unstable_effectOn -> effectOn
  • Updated docs
  • Bumps version to 6.0.0

todo:

  • Publish a copy of existing docs to https://easy-peasy-v5.vercel.app/

closes #765

@vercel
Copy link

vercel bot commented Jan 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
easy-peasy ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 18, 2023 3:40pm

@jmyrland jmyrland changed the title feat: Stabilize effectOn & prepare for v6.0.0 feat: Release effectOn & prepare for v6.0.0 Jan 19, 2023
- Refactors `unstable_effectOn` -> `effectOn`
- Updated docs
- Bumps version to `6.0.0`

todo:
- [ ] Publish a copy of existing docs to `https://easy-peasy-v5.vercel.app/`
Copy link
Collaborator

@no-stack-dub-sack no-stack-dub-sack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

However we should probably get @ctrlplusb's sign-off on this before merging given the significance of the PR / upcoming release.

Copy link
Collaborator

@no-stack-dub-sack no-stack-dub-sack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jmyrland jmyrland merged commit fcb53b9 into master Apr 18, 2023
@jmyrland jmyrland deleted the feat/release-effect-on branch April 18, 2023 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Community feedback on unstable_effectOn
2 participants