Updated "Using typed injections" for better type safety #463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #463 +/- ##
==========================================
+ Coverage 94.97% 97.72% +2.75%
==========================================
Files 18 20 +2
Lines 696 571 -125
Branches 139 104 -35
==========================================
- Hits 661 558 -103
+ Misses 30 11 -19
+ Partials 5 2 -3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
Hi! I'm a new collaborator for easy peasy, and I'm currently going through open github issues & PRs. I like this change! Are you able to resolve the conflicts? |
Updated the "Using typed injections" of the typescript tutorial to provide a more tightly bound example of typing the store injections. I believe this is more type safe than the original in the sense that there's now a single source of truth.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jmyrland
approved these changes
Sep 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the "Using typed injections" section of the typescript tutorial to provide a more tightly bound example of typing the store injections. I believe this is more type safe than the original in the sense that there's now a single source of truth.