🗑️ Clean up some validations

ctreminiom · Mar 5, 2023 · b8191cb · b8191cb
1 parent 8474cb7
commit b8191cb
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 10 deletions.
diff --git a/pkg/infra/models/jira_issue_custom_fields.go b/pkg/infra/models/jira_issue_custom_fields.go
@@ -2,7 +2,6 @@ package models
 
 import (
 	"bytes"
-	"fmt"
 	"github.com/perimeterx/marshmallow"
 )
 
@@ -350,9 +349,6 @@ func ParseSprintCustomField(buffer bytes.Buffer, customField string) ([]*SprintD
 			if wasFound {
 				record.CompleteDate = completeDate
 			}
-
-			fmt.Print(record)
-
 			records = append(records, record)
 		}
 

diff --git a/pkg/infra/models/sm_request_field.go b/pkg/infra/models/sm_request_field.go
@@ -15,12 +15,8 @@ type CreateCustomerRequestPayloadScheme struct {
 
 func (c *CreateCustomerRequestPayloadScheme) MergeFields(fields *CustomerRequestFields) (map[string]interface{}, error) {
 
-	if fields == nil {
-		return nil, fmt.Errorf("error, please provide a value *CustomFields pointer")
-	}
-
-	if len(fields.Fields) == 0 {
-		return nil, fmt.Errorf("error!, the Fields tag does not contains custom fields")
+	if fields == nil || len(fields.Fields) == 0 {
+		return nil, ErrNoCustomFieldError
 	}
 
 	//Convert the IssueScheme struct to map[string]interface{}