JRuby compatibility #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default, ObjectSpace.each_object is disabled in JRuby. However, ObjectSpace.each_object(Class) still works.
|
Sounds good, thanks! |
|
Confirmed to work fine in MRI 1.9.3. |
alexch
added a commit
that referenced
this pull request
Jul 27, 2012
JRuby ObjectSpace compatibility fix
lime
pushed a commit
to lime/annotate_models
that referenced
this pull request
Nov 5, 2013
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I attempt to run in JRuby, the follow error occurs:
By default,
ObjectSpace.each_objectis disabled in JRuby for performance reasons. However,ObjectSpace.each_object(Class)still works without enabling on the whole enchilada. I made this change and all the specs pass on MRI and JRuby, except for the integration tests (I'm having trouble getting the integration tests to pass on my machine even without the patch). Perhaps someone could verify that those pass as well.