Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor by adding AnnotateRoutes::Helpers #770

Merged
merged 3 commits into from
Mar 8, 2020
Merged

Refactor by adding AnnotateRoutes::Helpers #770

merged 3 commits into from
Mar 8, 2020

Conversation

nard-tech
Copy link
Collaborator

@nard-tech nard-tech commented Feb 29, 2020 •
edited
Loading

For further refactoring toward better architecture, I moved methods .strip_annotations, .extract_magic_comments_from_array and .real_content_and_header_position from AnnotateRoutes to AnnotateRoutes::Helpers.

@nard-tech
Copy link
Collaborator Author

nard-tech commented Feb 29, 2020 •
edited
Loading

cf. After refactoring, AnnotateRoutes will be like following link.

develop...nard-tech:feature/refactor_annotate_routes/processors (draft)

I would like to refactor AnnotateModels too because its maintability is too bad.
cf. https://codeclimate.com/github/ctran/annotate_models/lib/annotate/annotate_models.rb

@drwl
Copy link
Collaborator

drwl commented Mar 1, 2020

@nard-tech I'm confused as to what I should be reviewing. Should I just be reviewing commits 3a3b857, b1f7342, and 9cb8fc5?

@nard-tech
Copy link
Collaborator Author

@drwl I'm sorry to trouble you.
Please review only 3a3b857, b1f7342, and 9cb8fc5.

@nard-tech
Copy link
Collaborator Author

cf. After refactoring, AnnotateRoutes will be like following link.

develop...nard-tech:feature/refactor_annotate_routes/processors (draft)

I would like to refactor AnnotateModels too because its maintability is too bad.
cf. https://codeclimate.com/github/ctran/annotate_models/lib/annotate/annotate_models.rb

@drwl
This is just for reference.

drwl
drwl approved these changes Mar 8, 2020
View reviewed changes
Copy link
Collaborator

@drwl drwl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work. I apologize for the delay -- have been traveling.

@drwl drwl merged commit 060e7f2 into ctran:develop Mar 8, 2020
@nard-tech nard-tech deleted the feature/refactor_annotate_routes/helpers branch March 9, 2020 08:31
vfonic pushed a commit to vfonic/annotate_models that referenced this pull request May 8, 2020
@nard-tech @vfonic
Refactor by adding AnnotateRoutes::Helpers (ctran#770)
6e9b255 
For further refactoring toward better architecture, I moved methods `.strip_annotations`, `.extract_magic_comments_from_array` and `.real_content_and_header_position` from `AnnotateRoutes` to `AnnotateRoutes::Helpers`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drwl drwl drwl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nard-tech @drwl