-
Notifications
You must be signed in to change notification settings - Fork 631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor RSpec for AnnotateModels (4) - AnnotateModels.get_schema_info (without custom options) #735
Merged
drwl
merged 14 commits into
ctran:develop
from
nard-tech:feature/refactor_annotate_models/rspec/clean_v4
Jan 26, 2020
Merged
Refactor RSpec for AnnotateModels (4) - AnnotateModels.get_schema_info (without custom options) #735
drwl
merged 14 commits into
ctran:develop
from
nard-tech:feature/refactor_annotate_models/rspec/clean_v4
Jan 26, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nard-tech
force-pushed
the
feature/refactor_annotate_models/rspec/clean_v4
branch
from
January 20, 2020 20:48
aa12855
to
724a83f
Compare
@nard-tech what does changing the position of test cases do? |
drwl
approved these changes
Jan 26, 2020
vfonic
pushed a commit
to vfonic/annotate_models
that referenced
this pull request
May 8, 2020
…o (without custom options) (ctran#735) I refactored test cases of AnnotateModels without custom options.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I refactored test cases of AnnotateModels without custom options.
I will refactor the test case added in #602 in another PR.