Refactor RSpec for AnnotateModels (3) - AnnotateModels.get_schema_info (with custom options) #732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will refactor test cases of |
|
@reviewers |
Taking a look now. Good tip on |
drwl
approved these changes
Jan 20, 2020
| end | ||
| end | ||
|
|
||
| context 'when "hide_default_column_types" is "skip"' do |
There was a problem hiding this comment.
Reviewing this is interesting. I think there's a drift between test code and what we display in options from lib/annotate/parser.rb
vfonic
pushed a commit
to vfonic/annotate_models
that referenced
this pull request
May 8, 2020
* Structuralize RSpec test cases of AnnotateModels.get_schema_info (with custom options) * Replace expression expansion to plain text * Refactor RSpec test cases of AnnotateModels.get_schema_info (with custom options) * Change position of test cases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I refactored test cases of
AnnotateModelswith custom options.