Refactor RSpec for AnnotateModels #718
Conversation
nard-tech
force-pushed
the
feature/refactor_annotate_models/rspec/clean
branch
from
a0f37e5 to
64d38f4
Compare
|
🙌 thanks for doing this. Github has a hard time showing the changes so I'll carve out some time to review this. |
|
@drwl Thank you. I am waiting you to review this. After I made this PR, I notice that I can unify |
nard-tech
force-pushed
the
feature/refactor_annotate_models/rspec/clean
branch
from
dfdbe8a to
16d9738
Compare
There was a problem hiding this comment.
First off I want to say thank you for taking the time to refactor the specs. They are in pretty bad shape and after this refactor gets in they will be much better.
I went commit by commit to try and review but found these commits to be too big for me to review:
Would it be possible for you to split these ones up?
|
@drwl Thank you for your replying and pointing my mistakes out. As you requested
so I'd like to
May I continue to contribute in this way? |
Sure that sounds good to me. Again thanks for all this work, it is really appreciated 👍 |
|
@drwl All right, then I will close this commit. Thank you. |
I refactored and structuralized RSpec test cases of AnnotateModels for readability and scalability because it was too complex to read. cf. #718 In this PR, I refactored test cases of some methods in `AnnotateModels`. I will refactor test cases of other methods in another PR.
I refactored and structuralized RSpec test cases of AnnotateModels for readability and scalability because it was too complex to read. cf. ctran#718 In this PR, I refactored test cases of some methods in `AnnotateModels`. I will refactor test cases of other methods in another PR.
I refactored and structuralized RSpec test cases of AnnotateModels for readability and scalability because it was too complex to read.