Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Freeze constant AnnotateRoutes::HEADER_ROW #713

Merged
merged 1 commit into from
Jan 15, 2020
Merged

Freeze constant AnnotateRoutes::HEADER_ROW #713

merged 1 commit into from
Jan 15, 2020

Conversation

nard-tech
Copy link
Collaborator

As the change log shows, I froze the constant HEADER_ROW in accordance with the normal Ruby style regulation.

@drwl
Copy link
Collaborator

drwl commented Jan 15, 2020

Maybe in a follow up step could we use the magic string? # frozen_string_literal: true

@drwl drwl merged commit 3e3d605 into ctran:develop Jan 15, 2020
@nard-tech
Copy link
Collaborator Author

@drwl Oh, exactly it is better to add the magic comment # frozen_string_literal: true.
I'll try it in another PR.

@nard-tech nard-tech deleted the feature/refactor_annotate_routes/freeze_constant branch January 15, 2020 21:44
nard-tech added a commit to nard-tech/annotate_models that referenced this pull request Jan 16, 2020
@nard-tech
Merge branch 'feature/refactor_annotate_routes/extract_magic_comments…
ff08701 
…_from_array' into private/develop

* feature/refactor_annotate_routes/extract_magic_comments_from_array:
  Refactor AnnotateRoutes.header (ctran#714)
  Freeze constant AnnotateRoutes::HEADER_ROW (ctran#713)
  Add constants MAGIC_COMMENT_MATCHER (ctran#711)
vfonic pushed a commit to vfonic/annotate_models that referenced this pull request May 8, 2020
@nard-tech @vfonic
Freeze constant AnnotateRoutes::HEADER_ROW (ctran#713)
7cd339a 
As the change log shows, I froze the constant `HEADER_ROW` in accordance with the normal Ruby style regulation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drwl drwl drwl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nard-tech @drwl