Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix shifted when format_markdown option enabled and used non-ascii #650

Merged
merged 1 commit into from
Nov 9, 2019

Conversation

hasimoto1009
Copy link
Contributor

before
Screen Shot 2019-09-04 at 19 19 06

after
Screen Shot 2019-09-04 at 19 41 23

@hasimoto1009 hasimoto1009 force-pushed the fix-shift branch 2 times, most recently from c0eb433 to 79de6e3 Compare October 3, 2019 12:46
@drwl
Copy link
Collaborator

drwl commented Oct 4, 2019

@hasimoto1009 thanks for the PR! Would it be possible for you to add test(s) for this to show where it breaks and to prevent any future regressions?

@drwl drwl added the reviewed label Oct 4, 2019
@hasimoto1009
Copy link
Contributor Author

I'll try it. :)

@ctran ctran merged commit 693abdd into ctran:develop Nov 9, 2019
@ctran ctran added this to the v3.1.0 milestone Nov 9, 2019
peterfication pushed a commit to store2be/annotate_models that referenced this pull request Jan 20, 2020
vfonic pushed a commit to vfonic/annotate_models that referenced this pull request May 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants