Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix --models option description #649

Merged
merged 1 commit into from
Sep 16, 2019
Merged

Fix --models option description #649

merged 1 commit into from
Sep 16, 2019

Conversation

rnitta
Copy link
Contributor

@rnitta rnitta commented Sep 9, 2019

make compatible with README.md

@drwl
Copy link
Collaborator

drwl commented Sep 14, 2019

@rnitta thanks for this PR. Just curious what was the motivation for the change? Was the old description not helpful enough?

@rnitta
Copy link
Contributor Author

rnitta commented Sep 14, 2019

Is the old one correct?
In my understanding, --models option means "add schema annotation comments to rb files under app/models directory."

@drwl
Copy link
Collaborator

drwl commented Sep 16, 2019

That's a good point. It seems like it annotates ActiveRecord files that live in app/models. Thanks for the contribution @rnitta!

@drwl drwl merged commit 6de3ed8 into ctran:develop Sep 16, 2019
peterfication pushed a commit to store2be/annotate_models that referenced this pull request Jan 20, 2020
vfonic pushed a commit to vfonic/annotate_models that referenced this pull request May 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants