Make methods private in AnnotateRoutes #598
Conversation
lib/annotate/annotate_routes.rb
Outdated
| end | ||
| out << '' if magic_comments_map.any? | ||
|
|
||
| out += ["# #{options[:wrapper_open]}"] if options[:wrapper_open] |
There was a problem hiding this comment.
I know you didn't make this change, but out of curiosity do you know if there's a reason behind using << versus += [] for appending to an array?
There was a problem hiding this comment.
There's a semantic difference between them:
There was a problem hiding this comment.
That makes sense but this is mutating an array I believe. Line 43 is out = []
There was a problem hiding this comment.
Just tested it in Pry looks like the same applies regardless of if it's a String or an Array. Functionally it looks like one can be substituted over the other so would it makes sense to change the cases so they're the same?
|
👍 Changes look good to me. Looks a lot cleaner now that class methods are together in the singleton class rather than defined as |
|
@ctran unsure if you need anything else but it should be good to merge in as it's not changing any functionality. |
|
Planning on landing this in the next few days and bumping the gem version to |
First I tried to extend
AnnotateModels, but I found several problems inAnnotateModelsandAnnotateRoutes.In
AnnotateRoutes, there were many public methods that is not used in other classes or modules.Before my extension, I made these methods private and sort them in order of appearance.
All tests were passed.
Please trace each commits carefully. I didn't nothing special. The commits consist of coordinating code.
Note
As Code Climate shows, this gem is hard to maintain.
So I'd like to refactor this gem in the near future.