bundle exec annotate doesn't run on models, just routes

[jywei]

When I run bundle exec annotate --exclude tests,fixtures,factories,serializers, I will only get
config/routes.rb unchanged. (expectation: Model files unchanged. and config/routes.rb unchanged.
However, I need to run it with rake, with bundle exec rake annotate_models, annotate will finally run with my models.
It means my after migration auto-hook also doesn't work on models (also only routes)

annotate v2.7.4
Rails 5.1.4
ruby 2.5.1p57

if Rails.env.development?
  require 'annotate'
  task :set_annotation_options do
    # You can override any of these by setting an environment variable of the
    # same name.
    Annotate.set_defaults(
      'routes'                     => 'true',
      'position_in_routes'         => 'before',
      'position_in_class'          => 'before',
      'position_in_test'           => 'before',
      'position_in_fixture'        => 'before',
      'position_in_factory'        => 'before',
      'position_in_serializer'     => 'before',
      'show_foreign_keys'          => 'true',
      'show_complete_foreign_keys' => 'false',
      'show_indexes'               => 'false',
      'simple_indexes'             => 'false',
      'model_dir'                  => 'app/models',
      'root_dir'                   => '',
      'include_version'            => 'false',
      'require'                    => '',
      'exclude_tests'              => 'true',
      'exclude_fixtures'           => 'true',
      'exclude_factories'          => 'true',
      'exclude_serializers'        => 'true',
      'exclude_scaffolds'          => 'true',
      'exclude_controllers'        => 'true',
      'exclude_helpers'            => 'true',
      'exclude_sti_subclasses'     => 'false',
      'ignore_model_sub_dir'       => 'false',
      'ignore_columns'             => nil,
      'ignore_routes'              => nil,
      'ignore_unknown_models'      => 'false',
      'hide_limit_column_types'    => 'integer,boolean',
      'hide_default_column_types'  => 'json,jsonb,hstore',
      'skip_on_db_migrate'         => 'false',
      'format_bare'                => 'true',
      'format_rdoc'                => 'false',
      'format_markdown'            => 'false',
      'sort'                       => 'false',
      'force'                      => 'false',
      'classified_sort'            => 'true',
      'trace'                      => 'false',
      'wrapper_open'               => nil,
      'wrapper_close'              => nil,
      'with_comment'               => 'true'
    )
  end

  Annotate.load_tasks
end

TL;DR
Model annotation doesn't run on command line, only on rake version, HELP :(

[ctran]

@jywei Sorry, I don't quite understand what the problem is with your description.

Did this work on some version and stop working with certain version?

[jywei]

Model annotation only works when I run bundle exec rake annotate_models
It doesn't when I run bundle exec annotate --exclude tests,fixtures,factories,serializers or the callback after migration

[ZeroInputCtrl]

yea, my annotate stopped working once i upgraded to 2.7.4 when it goes to annotate migration and rollbacks. Only tries to annotate routes now. Was working on 2.7.2 except for the issues in #538
Using rails 5.0.6

[blimey85]

I'm having the same problem. bundle exec rake annotate_models works fine but just running annotate which is how I've called it previously, only updates my routes file.

[hallmatt]

I'm having the same problem with version 2.7.4. Rails 5.2.1

[tcox5698]

Hi! I'm having the same problem.
annotate (2.7.4)
rails (5.2.1)

I am able to work around it with: bundle exec rake annotate_models

[vladvinnikov]

I have same issue. It's added in #485.

Main reason - if you have routes = true in Annotate.set_defaults, then annotate_models doesn't called.
(Annotate.include_models? == false)

[jjercx]

I have same problem. annotate or bundle exec annotate does not annotate models. Only routes. And I have only changed auto_annotate_modes.rake in 'routes' => 'true'

# NOTE: only doing this in development as some production environments (Heroku)
# NOTE: are sensitive to local FS writes, and besides -- it's just not proper
# NOTE: to have a dev-mode tool do its thing in production.
if Rails.env.development?
  require 'annotate'
  task :set_annotation_options do
    # You can override any of these by setting an environment variable of the
    # same name.
    Annotate.set_defaults(
      'routes'                    => 'true',
      'position_in_routes'        => 'after',
      'position_in_class'         => 'before',
      'position_in_test'          => 'before',
      'position_in_fixture'       => 'before',
      'position_in_factory'       => 'before',
      'position_in_serializer'    => 'before',
      'show_foreign_keys'         => 'true',
      'show_complete_foreign_keys' => 'false',
      'show_indexes'              => 'true',
      'simple_indexes'            => 'false',
      'model_dir'                 => 'app/models',
      'root_dir'                  => '',
      'include_version'           => 'false',
      'require'                   => '',
      'exclude_tests'             => 'false',
      'exclude_fixtures'          => 'false',
      'exclude_factories'         => 'false',
      'exclude_serializers'       => 'false',
      'exclude_scaffolds'         => 'true',
      'exclude_controllers'       => 'true',
      'exclude_helpers'           => 'true',
      'exclude_sti_subclasses'    => 'false',
      'ignore_model_sub_dir'      => 'false',
      'ignore_columns'            => nil,
      'ignore_routes'             => nil,
      'ignore_unknown_models'     => 'false',
      'hide_limit_column_types'   => 'integer,boolean',
      'hide_default_column_types' => 'json,jsonb,hstore',
      'skip_on_db_migrate'        => 'false',
      'format_bare'               => 'true',
      'format_rdoc'               => 'false',
      'format_markdown'           => 'false',
      'sort'                      => 'false',
      'force'                     => 'false',
      'classified_sort'           => 'true',
      'trace'                     => 'false',
      'wrapper_open'              => nil,
      'wrapper_close'             => nil,
      'with_comment'              => true
    )
  end

  Annotate.load_tasks
end

It does not work after migrate either.

Ruby 2.5.3
Rails 5.2.1
annotate 2.7.4

[dinjas]

FWIW, I have noticed that any time I use the -r flag annotate will only update annotations in the routes file.

[ksouthworth]

I'm also experiencing this, any idea when v2.7.5 release is coming with the fix? Thanks!

[jmschneider]

I'm also experiencing this. Does this relate to the changes from issue #485?

[alexventuraio]

I have the same problem, after modifying the options 'routes' => 'true', when running rake db:migrate it just don't work anymore until manually run be rake annotate_models.

Ruby: 2.5.3
Rails: 5.2.0
Annotate: 2.7.4

[ctran]

2.7.5 was released a few days ago. I'm not sure if this particular issue is fixed though so if someone can confirm.

[hallmatt]

I'm on annotate v2.7.5. Running annotate seems to just annotate the routes.
Rails 6 rc1, ruby 2.5.1

Also running rake annotate -p after has the following error:

NameError: undefined local variable or method `after' for #<Rake::Application:0x00007fb587135da0>

[drwl]

Sorry for the delay everyone. This is my first time working with an open source project using the Github features like milestones for releases. I've since removed the v2.7.5 milestone and added v3.0.0.

I'll be taking a look at this for the v3 release.

[drwl]

Just closing the loop for everyone, I added a fix for this issue. Will cut and publish the new gem shortly.

[ksouthworth]

Great! thanks so much

[alexventuraio]

Great @drwl, but how do we know when the update is ready? is there a way to do it within the rails app or we need to go to ruby gems to check this out manually?

[drwl]

Just waiting for some help from @ctran (repo owner) to push it to Rubygems. In the mean time you could make your gemfile point to this git repository. https://bundler.io/guides/git.html

On Tue, Sep 3, 2019 at 7:52 AM Alejandro Ventura ***@***.***> wrote: Great @drwl <https://github.com/drwl>, but how do we know when the update is ready? is there a way to do it within the rails app or we need to go to ruby gems to check this out manually? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#563?email_source=notifications&email_token=AAKMUC5QQ6ZGW7F36UTLTTTQHZ235A5CNFSM4FDIHRP2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5YO2DQ#issuecomment-527494414>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAKMUC2ZODMTNZM2TIVJSQDQHZ235ANCNFSM4FDIHRPQ> .

-- Sent from phone