-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow custom progressbar consumers #54
Conversation
Hi Alex, thanks for this! Compatibility with SLF4J is of utmost importance -- I haven't got time to do it myself. Could you shed some light on how this extension would make it work with SLF4J, so that I could gain a better understanding of the underlying issue? You can paste a snippet here, or you could add a test that depends on SLF4J. |
Yes, you are completely right. I added a new The idea is that for each progress bar update the state is printed to the logger, without the carriage return.This logs the progress over time. As an example
|
Thanks a lot @alexpeelman -- I'll review this when I got some time (hopefully this weekend). |
Hi just a small check if you are planning to review this any time soon ? No pressure just asking for an update here :) |
Hooray! I merged this after some modifications to your code. See documentation at https://tongfei.me/progressbar/loggers/. Thanks @alexpeelman ! |
Awesome ! Nice idea to introduce the renderer 👍 |
Now deployed as version |
Hi, I extended this incredible useful tool a bit to allow any kind of consumer to print the progress bar. I need this to write the progress to an SLF4J log.