Fix Slow Exit #51
Merged
Fix Slow Exit #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh yeah, totally. I didn't even see the issue 👍 |
|
I'll merge your PR this weekend and release |
|
(gentle poke) |
ctongfei
reviewed
May 20, 2019
| public void run() { | ||
| try { | ||
| while (!killed) { | ||
| while (!Thread.interrupted()) { |
There was a problem hiding this comment.
There should be a refresh() in the catch clause.
|
Thanks a lot :-) I've fixed your bug and published |
|
Awesome. Thanks. Also apparently you know @HunterJHU :) |
This was referenced Mar 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At present progressbar version
0.7.3will take on averageupdateInterval / 2milliseconds to terminate, and for very short runs, will take a minimum ofupdateIntervalto complete itsclose()handler.This patch fixes that by explicitly interrupting the
ProgressThreadas opposed to waiting for an internal semaphore to cleanup on the inner loop.