Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use finely grained jline-terminal rather than bundle jar jline. #159

Merged
merged 1 commit into from
Jan 2, 2024
Merged

Use finely grained jline-terminal rather than bundle jar jline. #159

merged 1 commit into from
Jan 2, 2024

Conversation

brett-smith
Copy link
Contributor

While investigating #158, I was pleased to find the progressbar only actually needs jline-terminal. This PR changes the POM and module-info to use that finely grained library.

This will make it impossible to use progressbar with the jline bundle in modular applications. This however seems more sensible than the current situation which is reversed

@ctongfei ctongfei changed the base branch from main to 0.10.1 January 2, 2024 06:20
@ctongfei ctongfei merged commit 7becb42 into ctongfei:0.10.1 Jan 2, 2024
@ctongfei
Copy link
Owner

ctongfei commented Jan 2, 2024

Thanks @brett-smith ! This fixes #158.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants