Issue hotfix #198
Issue hotfix #198
Conversation
| @@ -22,9 +25,11 @@ def getVersionFromFile(): | |||
| url='https://github.com/ctlearn-project/ctlearn', | |||
| license='BSD-3-Clause', | |||
| packages=['ctlearn'], | |||
| install_requires=getRequirements(), | |||
There was a problem hiding this comment.
You should not duplicate information between pyproject.toml and setup.py.
This can lead to confusion and errors.
After you introduced pyproject.toml with all the configurations you provided, you should just remove the setup.py.
| @@ -9,6 +9,9 @@ def getVersionFromFile(): | |||
|
|
|||
| here = path.abspath(path.dirname(__file__)) | |||
|
|
|||
| def getRequirements(): | |||
| return open("docs/requirements.txt").readlines() | |||
There was a problem hiding this comment.
Requirements for building the docs should go into the project.optional-dependencies section of pyproject.toml
There was a problem hiding this comment.
There was a problem hiding this comment.
We have the dependencies in the setup.py and in the dependencies section in the pyproject.toml file, they should also be included in the optional-dependencies? In our case they are not optional
dependencies = [
"dl1_data_handler>=0.12.0",
"astropy",
"matplotlib",
"numpy",
"pandas",
"pip",
"pyyaml",
"scikit-learn",
"ctaplot",
"numba>=0.56.2,<0.57",
"tensorflow>=2.15,<2.16",
"pydot",
"pyirf",
]
There was a problem hiding this comment.
I misunderstood then. I thought docs/requirements.txt are additional requirements that are needed to build the documentation (e.g. sphinx)
Issue solving #195 and #196