Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: throw empty error in extractAllToAsync on operation done #437

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

Autokaka
Copy link
Contributor

When extraction for each fileEntry is done, on should callback first before deleting the entry since the implementation of done function will always check and throw if current fileEntries is empty.

@cthackers cthackers merged commit 71a1035 into cthackers:master Mar 13, 2024
@EnigmaJJ
Copy link

const done = () => { if (fileEntries.size === 0) { callback(); } };
I found callback is not be called because fileEntries.size is never zero?

@jakebailey
Copy link

This caused a regression: #475

@komyg
Copy link

komyg commented Mar 21, 2024

I had the same problem. The done callback is never called.

@bimalkjha
Copy link

So, the check for fileEntries.size should be removed if intension is to call callback first before fileEntries.delete(entry);. i.e. just replace done(); with callback();. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants