Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct help text #57

Merged
merged 1 commit into from
Oct 24, 2020
Merged

correct help text #57

merged 1 commit into from
Oct 24, 2020

Conversation

mziraki
Copy link
Contributor

@mziraki mziraki commented Oct 22, 2020

No description provided.

@mziraki mziraki mentioned this pull request Oct 22, 2020
@ctessier
Copy link
Owner

Hi @mziraki,

Thanks for the PR!
Could you just please explain to me what in Nova made this change necessary. I can't find what I am looking for.

Also, did you upgrade Cropper.js? The lock file is not in your PR and I'd rather seperate this from your fix.

Thank you!

@mziraki
Copy link
Contributor Author

mziraki commented Oct 24, 2020

Hi @mziraki,

Thanks for the PR!
Could you just please explain to me what in Nova made this change necessary. I can't find what I am looking for.

Also, did you upgrade Cropper.js? The lock file is not in your PR and I'd rather seperate this from your fix.

Thank you!

Hi @ctessier,

it's for #56 issue, new nova versions need help text passing to default field vue component to show, you can check "resources\js\components\Form\FileField.vue" for better understanding of the issue. (I just paste the standard file field vue component code to fix it :D)

and vue cropper package upgrade was not intentional, it happend in bundling process because version in package.json is not strict.

@ctessier ctessier merged commit 3a9d481 into ctessier:1.x Oct 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants