Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

129 Implement Volunteers Page #54

Merged
merged 3 commits into from
Mar 29, 2024
Merged

129 Implement Volunteers Page #54

merged 3 commits into from
Mar 29, 2024

Conversation

tig-github
Copy link
Member

Authors:
brelieu05, tig-github

What does this PR contain?

  • Backend route for getting all volunteers and the count of every event they went to

How did you test these changes?

  • Tested Query on pgadmin
  • Tested route on Postman
  • Successfully renders volunteers and their counts in the frontend table

Closes #129

routes/data.js Outdated Show resolved Hide resolved
Comment on lines +143 to 144

dataRouter.get('/volunteer/:volunteerId', async (req, res) => {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete

Suggested change
dataRouter.get('/volunteer/:volunteerId', async (req, res) => {
dataRouter.get('/volunteer/:volunteerId', async (req, res) => {

Comment on lines +340 to +341

// get all volunteers and how many events they are in

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete

Suggested change
// get all volunteers and how many events they are in
// get all volunteers and how many events they are in

`,
);
res.status(200).json(profileEventCount.rows);
} catch (err) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Delete ··

Suggested change
} catch (err) {
} catch (err) {

Copy link
Collaborator

@Aokijiop Aokijiop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Made some changes for eslint.

@Aokijiop Aokijiop merged commit 349f331 into dev Mar 29, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Volunteers Page
4 participants