Skip to content
This repository has been archived by the owner on Feb 8, 2022. It is now read-only.

Need encoding support for required fields #68

Closed
jhugard opened this issue Feb 15, 2017 · 0 comments
Closed

Need encoding support for required fields #68

jhugard opened this issue Feb 15, 2017 · 0 comments
Assignees
@jhugard

Comments

@jhugard
Copy link
Collaborator

jhugard commented Feb 15, 2017 •
edited
Loading

Functions in the Encode module assume that "0" or "default" values should be elided (not serialized). However, in proto2, required fields must appear in the serialization stream, even if they have the default value.

Please add Encode module functions to support required fields. Encode.fromNondefaultedVarint exists, but none of the other data types are supported.
@jhugard jhugard self-assigned this Feb 15, 2017
jhugard added a commit that referenced this issue Feb 16, 2017
@jhugard
Issue #68 - Add Encoder support for proto2 *required* fields
764ebca
jhugard added a commit that referenced this issue Feb 16, 2017
@jhugard
Issue #68 - Add Encoder support for proto2 *required* fields
681324c
jhugard added a commit that referenced this issue Feb 23, 2017
@jhugard
Issue #68 - Add Encoder support for proto2 *required* fields (#69)
717ae69 
Pulling this into master so it goes out with the next release.
@jhugard jhugard closed this as completed Feb 23, 2017
@jhugard jhugard mentioned this issue Apr 19, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jhugard jhugard

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jhugard