This repository has been archived by the owner on Apr 16, 2020. It is now read-only.
Add support for detecting and writing source link files for submodules #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see that the issue you wanted to wait for was closed recently. Does that mean progress can start being made on this? It would be nice to be able to step into code that is in a submodule since the Visual Studio debugger won't step into embedded PDB files. |
|
I am not yet comfortable with this pull request. It needs unit tests, and a more thorough review than I've given it so far. I appreciate the effort and I'd like to see submodules supported. |
|
If I can I will see if I can write tests but I may not get to it...I think that setup is pretty new right? |
|
I'm hoping this can be addressed in Microsoft.Build.Tasks.Git in the SourceLink 3 timeframe. The design will be discussed in #305. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.