Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add diff and json feature to eventio_print_simtel_metaparams #273

Merged
merged 2 commits into from
Feb 15, 2024

Conversation

maxnoe
Copy link
Member

@maxnoe maxnoe commented Feb 14, 2024

Allows passing --tel-diff 1 2 to compare the meta parameters of two telescopes, e.g.:

❯ eventio_print_simtel_metaparams prod6_test_files/gamma_20deg_0deg_run000001___cta-prod6-2156m-LaPalma-dark+magic_cone10.simtel.zst --tel-diff 1 2
--- 

+++ 

@@ -1,21 +1,29 @@

-NIGHTSKY_BACKGROUND = all: 0.233591 
+NIGHTSKY_BACKGROUND = all: 0.241539 
 NSB_AUTOSCALE_AIRMASS = 0.84 0.29 
 MIRROR_CLASS = 0 
 FOCUS_OFFSET = 6.55 0 0 0 
 FOCAL_Length = 2800 
 EFFECTIVE_FOCAL_Length = 2923.7 0 0 0 0 
-MIRROR_LIST = mirror_CTA-N-LST1_v2019-03-31.dat
+MIRROR_LIST = mirror_CTA-N-LST2_v2020-04-07_rotated.dat
 CAMERA_DEGRADED_EFFICIENCY = 1 
 CAMERA_DEGRADED_MAP = none
 MIRROR_DEGRADED_REFLECTION = 0.8 
 PRIMARY_DEGRADED_MAP = none
 DEFAULT_TRIGger = AnalogSum
-CAMERA_CONFIG_FILE = camera_CTA-LST-1_analogsum21_v2020-04-14.dat
+CAMERA_CONFIG_FILE = camera_CTA-LST-234_analogsum21_v2020-04-14.dat
 OPTICS_CONFIG_NAME = LST
-OPTICS_CONFIG_VARIANT = LSTN-01 prototype
+OPTICS_CONFIG_VARIANT = LSTN-02
 OPTICS_CONFIG_VERSION = 2023-12-15 (Prod-6)
 CAMERA_CONFIG_NAME = LSTcam
-CAMERA_CONFIG_VARIANT = LST-1(N) prototype, with nsb_autoscale_airmass
+CAMERA_CONFIG_VARIANT = LSTN-02 camera, with auto-scaling NSB levels
 CAMERA_CONFIG_VERSION = 2022-07-01 (Prod-6)
+RANDOM_MONO_PROBability = 0.01 
+PARABOLIC_DISH = 1 
+DISH_SHAPE_Length = 2800 
+MIRROR_FOCAL_Length = 0 
+DISCRIMINATOR_PULSE_SHAPE = LST_pulse_shape_7dynode_high_intensity_pix1s.dat
+ASUM_THRESHold = 260.7 
+ASUM_CLIPping = 9999 
+ASUM_SHAPING_FILE = none
 MIRROR_DIAMETER = 24.774 m
 MIRROR_AREA = 386.97 m^2

Also added the --json flag to output as json

Copy link

codecov bot commented Feb 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (16a6061) 86.58% compared to head (b2d8b69) 86.81%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #273      +/-   ##
==========================================
+ Coverage   86.58%   86.81%   +0.22%     
==========================================
  Files          24       24              
  Lines        2222     2252      +30     
==========================================
+ Hits         1924     1955      +31     
+ Misses        298      297       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

orelgueta
orelgueta previously approved these changes Feb 15, 2024
Copy link
Contributor

@orelgueta orelgueta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good (small comment about user-friendliness).

src/eventio/scripts/print_simtel_metaparams.py Outdated Show resolved Hide resolved
@maxnoe maxnoe merged commit 87d6314 into main Feb 15, 2024
6 checks passed
@maxnoe maxnoe deleted the diff_metaparams branch February 15, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants