Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement type 2033, PixelMonitoring, fixes #243 #244

Merged
merged 1 commit into from
Jun 2, 2022
Merged

Implement type 2033, PixelMonitoring, fixes #243 #244

merged 1 commit into from
Jun 2, 2022

Conversation

maxnoe
Copy link
Member

@maxnoe maxnoe commented May 16, 2022 •
edited
Loading

No description provided.

@maxnoe maxnoe changed the title Type2033 Implement type 2033, PixelMonitoring, fixes #243 May 16, 2022
@codecov
Copy link

codecov bot commented May 16, 2022 •
edited
Loading

Codecov Report

Merging #244 (ee9bcad) into master (09d1aca) will increase coverage by 1.10%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #244      +/-   ##
==========================================
+ Coverage   86.12%   87.23%   +1.10%     
==========================================
  Files          24       24              
  Lines        2105     2491     +386     
==========================================
+ Hits         1813     2173     +360     
- Misses        292      318      +26
Impacted Files Coverage Δ
eventio/simtel/__init__.py 100.00% <ø> (ø)
eventio/simtel/objects.py 84.08% <100.00%> (+3.73%) ⬆️
eventio/simtel/simtelfile.py 97.69% <100.00%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09d1aca...ee9bcad. Read the comment docs.

@maxnoe maxnoe requested a review from kosack May 16, 2022 15:08
@maxnoe maxnoe requested a review from orelgueta June 2, 2022 09:37
orelgueta
orelgueta reviewed Jun 2, 2022
View reviewed changes
Copy link
Contributor

@orelgueta orelgueta left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests are dependent on the file being for a camera with 2 gains. Maybe it's OK, but it's perhaps better to make the test work also for a single gain camera.

tests/simtel/test_simtel_objects.py Outdated Show resolved Hide resolved
tests/simtel/test_simtel_objects.py Outdated Show resolved Hide resolved
tests/simtel/test_simtelfile.py Outdated Show resolved Hide resolved
@maxnoe
Copy link
Member Author

maxnoe commented Jun 2, 2022

@orelgueta I exchanged the test file for a file containing telescopes with both one and two gains

orelgueta
orelgueta approved these changes Jun 2, 2022
View reviewed changes
Copy link
Contributor

@orelgueta orelgueta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now!

@maxnoe maxnoe merged commit cb83102 into master Jun 2, 2022
@maxnoe maxnoe deleted the type2033 branch June 2, 2022 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orelgueta orelgueta orelgueta approved these changes

@kosack kosack Awaiting requested review from kosack

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maxnoe @orelgueta