-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DQM database and web application #72
Conversation
After discussion with Victor at LPNHE, better not to expose the primary DB in write access to the world. Instead of pushing DQM output from DIRAC workers to the DB, better pulling the DQM FITS output files from the primary VM.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #72 +/- ##
=========================================
+ Coverage 0.38% 3.08% +2.69%
=========================================
Files 30 36 +6
Lines 3404 3571 +167
=========================================
+ Hits 13 110 +97
- Misses 3391 3461 +70
☔ View full report in Codecov by Sentry. |
Would it be too much to ask to add a test routine for this new material before the PR is merged? |
Hi @tibaldo, It would be tough to implement extensive unit tests without actually deploying the overall VM infrastructure, but I can certainly implement some, at least for the data base utilities and maybe on the bokeh side. |
Hi @tibaldo , I think I found a way to extensively test all these new features, using an in-memory data base for unit tests. This PR is ready for another review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jlenain, thanks a lot for this impressive amount of work! Using the ZEO/ZODB servers and running tests via an in-memory instance looks like a very clever and effective solution.
I only have two minor comments on hard-coding the camera geometry to be used, but otherwise the PR looks good to be merged to me.
…e geometry version.
…oding the geometry version." This reverts commit c8d09f7.
…once this PR is merged
This PR introduces the web application for the Data Quality Monitoring tool, as well as all the needed recipes to setup the accompanying infrastructure (database configuration, recipes to create the two needed virtual machine on a local cloud with e.g. OpenStack).