Change name of the longterm script

[marialainez]

longterm_dl1_check.py script renamed to lstchain_longterm_dl1_check.py

[morcuended]

Thanks, @marialainez! This would work. However, once lstchain PR cta-observatory/cta-lstchain#881 is merged it would be possible to simply use the command lstchain_longterm_dl1_check without giving the entire path.

Then there is no need to include it in the cfg, but directly in closer.py (daily_longterm_cmd function).

You have also to adapt the test to make it pass:

lstosa/osa/scripts/tests/test_osa_scripts.py

Lines 316 to 328 in 0e595ce

	expected_cmd = [
	"sbatch",
	"-D",
	options.directory,
	"-o",
	"log/longterm_daily_%j.log",
	"--dependency=afterok:12345,54321",
	"/fefs/aswg/software/virtual_env/ctasoft/cta-lstchain/lstchain/scripts/longterm_dl1_check.py",
	"--input-dir=test_osa/test_files0/DL1/20200117/v0.1.0/tailcut84",
	"--output-file=test_osa/test_files0/OSA/DL1DataCheck_LongTerm/v0.1.0/20200117/DL1_datacheck_20200117.h5",
	"--muons-dir=test_osa/test_files0/DL1/20200117/v0.1.0",
	"--batch"
	]

Line 323 should simply be "lstchain_longterm_dl1_check", the same change goes in closer.py where this command is issued.

[morcuended]

We can remove this path from here and directly use the lstchain entry point lstchain_longterm_dl1_check in closer.py

[codecov]

Codecov Report

Merging #98 (38f0aa4) into main (c3a92d8) will decrease coverage by 0.09%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #98      +/-   ##
==========================================
- Coverage   81.93%   81.83%   -0.10%     
==========================================
  Files          43       43              
  Lines        4450     4449       -1     
==========================================
- Hits         3646     3641       -5     
- Misses        804      808       +4     

Impacted Files	Coverage Δ
osa/scripts/closer.py	75.53% <ø> (-0.13%)	⬇️
osa/scripts/tests/test_osa_scripts.py	98.82% <ø> (ø)
osa/utils/utils.py	67.28% <0.00%> (-1.41%)	⬇️
osa/utils/tests/test_utils.py	97.72% <0.00%> (-1.14%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3a92d8...38f0aa4. Read the comment docs.