Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement new calibration pipeline #57

Merged
merged 64 commits into from
Dec 23, 2021
Merged

Implement new calibration pipeline #57

merged 64 commits into from
Dec 23, 2021

Conversation

morcuended
Copy link
Member

@morcuended morcuended commented Dec 19, 2021

Summary of the changes:

  • Pipe the two onsite calibration scripts from lstchain
  • Adapt history files to new calibration steps (to assure the new scripts run successfully)
  • Update the paths according to the new calibration paths in r0 to dl1
  • Search for previously produced time calibration file to be used in r0 to dl1
  • Adapt closer, do not need to transfer calibration products anymore
  • Update unit tests

To be done in a separated PR:

Closes #54

@codecov
Copy link

codecov bot commented Dec 19, 2021

Codecov Report

Merging #57 (e91c42f) into main (f73c7f9) will increase coverage by 1.42%.
The diff coverage is 96.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #57      +/-   ##
==========================================
+ Coverage   79.01%   80.43%   +1.42%     
==========================================
  Files          38       38              
  Lines        4112     4120       +8     
==========================================
+ Hits         3249     3314      +65     
+ Misses        863      806      -57     
Impacted Files Coverage Δ
osa/utils/utils.py 69.08% <ø> (-0.49%) ⬇️
osa/scripts/datasequence.py 87.12% <80.00%> (ø)
osa/job.py 78.28% <89.23%> (+3.28%) ⬆️
osa/scripts/tests/test_osa_scripts.py 97.12% <93.93%> (-1.62%) ⬇️
osa/scripts/calibration_pipeline.py 96.22% <96.22%> (ø)
osa/conftest.py 100.00% <100.00%> (ø)
osa/nightsummary/tests/test_nightsummary.py 100.00% <100.00%> (ø)
osa/report.py 88.70% <100.00%> (+2.55%) ⬆️
osa/scripts/closer.py 69.10% <100.00%> (-0.52%) ⬇️
osa/scripts/sequencer.py 86.80% <100.00%> (+0.59%) ⬆️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f73c7f9...e91c42f. Read the comment docs.

@morcuended morcuended merged commit 76c5a64 into main Dec 23, 2021
@morcuended morcuended deleted the calib branch December 23, 2021 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use onsite scripts from lstchain
1 participant