-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add argument to allow the selection of the tool for the gain selection #289
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine, but I leave some comments in case they are helpful to improve the code usability
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, it might be good to change the name of the script if it will be running both gain selection and DVR?
Co-authored-by: Daniel Morcuende <[email protected]>
This script at the moment is not used to run the DVR, I think the script "lstchain_r0g_to_r0v" should be used for that, which we don't use here. |
isn't it the |
|
Understood. I think it is good to go, test failed is unrelated, due to a difference in the time shown in the sequencer table (happens from time to time) |
By default, lstchain_r0_to_r0g will be used for dates later than 20231205 and lst_dvr for dates previous to it. But if we want to use e.g. lstchain_r0_to_r0g for a date previous to 20231205, we can do it now using the argument "tool". This is necessary for some days of November of 2023, in which some data was taken with EvBV6.