Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add argument to allow the selection of the tool for the gain selection #289

Merged
merged 3 commits into from
May 9, 2024

Conversation

marialainez
Copy link
Collaborator

By default, lstchain_r0_to_r0g will be used for dates later than 20231205 and lst_dvr for dates previous to it. But if we want to use e.g. lstchain_r0_to_r0g for a date previous to 20231205, we can do it now using the argument "tool". This is necessary for some days of November of 2023, in which some data was taken with EvBV6.

Copy link
Member

@morcuended morcuended left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, but I leave some comments in case they are helpful to improve the code usability

src/osa/scripts/gain_selection.py Show resolved Hide resolved
Copy link
Member

@morcuended morcuended left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, it might be good to change the name of the script if it will be running both gain selection and DVR?

@marialainez
Copy link
Collaborator Author

This script at the moment is not used to run the DVR, I think the script "lstchain_r0g_to_r0v" should be used for that, which we don't use here.

@morcuended
Copy link
Member

morcuended commented May 9, 2024

isn't it the lst_dvr then doing actually DVR? (ok, it is just the name for the "old" data, it's actually doing both things, no?)

@marialainez
Copy link
Collaborator Author

marialainez commented May 9, 2024

lst_dvr can do both things, gain selection and dvr, but in this script we only use it for the gain selection:

[lstanalyzer@tcs06 lstosa]$ lst_dvr --help
Tool to apply gain selection and data volume reduction to LST R0 zfits files

Usage for DVR including gain selection:
lst_dvr <input file> <output directory> <pixel selection file>

Usage for gain selection only:
lst_dvr <input file> <output directory> <reference time> <reference counter> <module> <preferred trigger source>

@morcuended
Copy link
Member

Understood. I think it is good to go, test failed is unrelated, due to a difference in the time shown in the sequencer table (happens from time to time)

@morcuended morcuended merged commit 284a1d2 into main May 9, 2024
1 of 5 checks passed
@morcuended morcuended deleted the gainsel branch May 9, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants