Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change "&" by "and" in the while checking the status of autocloser jobs #284

Merged
merged 2 commits into from
Mar 8, 2024
Merged

Change "&" by "and" in the while checking the status of autocloser jobs #284

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1dbad7d
Change & by and in the while checking the status of closer jobs
marialainez Mar 8, 2024
f5e2512
Write date in string format to send the email
marialainez Mar 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/osa/scripts/closer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@
# before creating the NightFinished.txt file
n_max = 6
n = 0
while not all_closer_jobs_finished_correctly() & n <= n_max:
while not all_closer_jobs_finished_correctly() and n <= n_max:
log.info(
"All jobs launched by autocloser did not finished correctly yet. "
"Checking again in 10 minutes..."
Expand All @@ -202,7 +202,7 @@
n += 1

if n > n_max:
send_warning_mail(date=options.date)
send_warning_mail(date=date_to_iso(options.date))

Check warning on line 205 in src/osa/scripts/closer.py

View check run for this annotation

Codecov / codecov/patch

src/osa/scripts/closer.py#L205 

Added line #L205 was not covered by tests
return False

if options.seqtoclose is None:
Expand Down
Loading